Fix #1808: toNumber() not working on a unitless unit

josdejong · Apr 8, 2020 · 5cd1849 · 5cd1849
1 parent f6a8a23
commit 5cd1849
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/type/unit/Unit.js b/src/type/unit/Unit.js
@@ -880,7 +880,7 @@ export const createUnitClass = /* #__PURE__ */ factory(name, dependencies, ({
       other = this.clone()
     }
 
-    if (other._isDerived()) {
+    if (other._isDerived() || other.units.length === 0) {
       return other._denormalize(other.value)
     } else {
       return other._denormalize(other.value, other.units[0].prefix.value)

diff --git a/test/unit-tests/type/unit/Unit.test.js b/test/unit-tests/type/unit/Unit.test.js
@@ -231,6 +231,11 @@ describe('Unit', function () {
       const u = new Unit(math.fraction(5), 'cm')
       assert.strictEqual(u.toNumber('mm'), 50)
     })
+
+    it('should convert a unit with value only to a number', function () {
+      const u = Unit.parse('5', { allowNoUnits: true })
+      assert.strictEqual(u.toNumber(), 5)
+    })
   })
 
   describe('toNumeric', function () {
@@ -349,6 +354,11 @@ describe('Unit', function () {
       assert.strictEqual(u4.fixPrefix, true)
     })
 
+    it('should convert a unitless quantity', function () {
+      const u = Unit.parse('5', { allowNoUnits: true })
+      assert.strictEqual(u.toNumeric(), 5)
+    })
+
     it('should convert a binary prefixes (1)', function () {
       const u1 = new Unit(1, 'Kib')
       assert.strictEqual(u1.value, 1024)