Support for streaming large documents #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/jsonRepairProxy.ts # src/jsonrepair.test.ts
# Conflicts: # src/jsonrepair.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement streaming support in Node.js and the CLI
See #106
Important to note is that for now I've implemented the streaming version alongside the regular function. The streaming version can be wrapped such that it acts like the regular version, but it works with a limited buffer which can possibly throw an "Index out of range" error when repairing a document with a string that is larger than the configured buffer. It is possible to configure
bufferSize: Infinity, but that has a negative impact on the performance, making it slower than the regular version. Also, the regular version is much less code, so better suitable for use in the browser. Both implementations are tested against the same extensive set of unit tests to make sure they behave the same.