Skip to content

Commit

Permalink
update defaults on C++ as well
Browse files Browse the repository at this point in the history
  • Loading branch information
jorisvandenbossche committed Oct 5, 2023
1 parent ed1b46f commit 0c21100
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
7 changes: 4 additions & 3 deletions cpp/src/parquet/arrow/arrow_reader_writer_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2354,10 +2354,11 @@ void TestGetRecordBatchReader(

TEST(TestArrowReadWrite, GetRecordBatchReader) { TestGetRecordBatchReader(); }

// Same as the test above, but using coalesced reads.
TEST(TestArrowReadWrite, CoalescedReads) {
// Same as the test above, but using non-coalesced reads.
TEST(TestArrowReadWrite, NoneCoalescedReads) {
ArrowReaderProperties arrow_properties = default_arrow_reader_properties();
arrow_properties.set_pre_buffer(true);
arrow_properties.set_pre_buffer(false);
arrow_properties.set_cache_options(::arrow::io::CacheOptions::Defaults())
TestGetRecordBatchReader(arrow_properties);
}

Expand Down
4 changes: 2 additions & 2 deletions cpp/src/parquet/properties.h
Original file line number Diff line number Diff line change
Expand Up @@ -831,8 +831,8 @@ class PARQUET_EXPORT ArrowReaderProperties {
: use_threads_(use_threads),
read_dict_indices_(),
batch_size_(kArrowDefaultBatchSize),
pre_buffer_(false),
cache_options_(::arrow::io::CacheOptions::Defaults()),
pre_buffer_(true),
cache_options_(::arrow::io::CacheOptions::LazyDefaults()),
coerce_int96_timestamp_unit_(::arrow::TimeUnit::NANO) {}

/// \brief Set whether to use the IO thread pool to parse columns in parallel.
Expand Down

0 comments on commit 0c21100

Please sign in to comment.