Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci lint #76

Merged
merged 15 commits into from
Jul 17, 2024
Merged

Conversation

ccoVeille
Copy link
Contributor

  • chore: use Go canonical way to return errors
  • chore: use the canonical name for error variable
  • ci: add golangci-lint configuration file
  • fix: catch errors reported by errcheck linter
  • fix: make sure to catch all errors in drivers
  • ci: enable more linters
  • chore: fix import orders
  • chore: remove dot import and use type alias
  • chore: remove else when previous if ends with a return
  • chore: remove type or default value when obvious
  • chore: use go initialism for variable name
  • chore: no uppercase constant in Go
  • chore: remove suspicious blank imports
  • fix: make sure to use the database name when getting table columns
  • ci: enable golang-lint in GitHub actions

Fixes #71

Related to #14

@jorgerojas26 jorgerojas26 merged commit f801157 into jorgerojas26:main Jul 17, 2024
1 check passed
@ccoVeille ccoVeille deleted the golangci-lint branch July 18, 2024 01:07
ccoVeille added a commit to ccoveille-forks/jorgerojas26-lazysql that referenced this pull request Jul 19, 2024

-
name: Golangci-lint
uses: golangci/[email protected]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm noticing I added this one on the release process, so only when something is tagged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by #80 80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve code quality by using golangci-lint
2 participants