-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golangci lint #76
Merged
jorgerojas26
merged 15 commits into
jorgerojas26:main
from
ccoveille-forks:golangci-lint
Jul 17, 2024
Merged
golangci lint #76
jorgerojas26
merged 15 commits into
jorgerojas26:main
from
ccoveille-forks:golangci-lint
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way the code is clearer. The changes were made on a limited set of files, that are about to be refactored or fixed.
here there was an import shadowing of the error interface nothing should be ever named "error"
errors cannot be ignored
use the following command gci write -s standard -s default -s localmodule
improve code readability
database variable was not used
ccoVeille
added a commit
to ccoveille-forks/jorgerojas26-lazysql
that referenced
this pull request
Jul 19, 2024
ccoVeille
commented
Jul 19, 2024
|
||
- | ||
name: Golangci-lint | ||
uses: golangci/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm noticing I added this one on the release process, so only when something is tagged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed by #80 80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
Related to #14