Backward compatible support for ADIOS2 2.10.x #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
reviewed
Feb 8, 2024
src/adios4dolfinx/adios2_helpers.py
Outdated
Comment on lines
8
to
11
| if (packaging.version.parse(adios2.__version__) | ||
| >= packaging.version.Version("2.10.0")): | ||
| adios2 = adios2.bindings | ||
|
|
There was a problem hiding this comment.
Could we use:
https://docs.python.org/3/library/importlib.metadata.html
for the versioning?
There was a problem hiding this comment.
Or something like
try:
import adios2.bindings as adios2
except ImportError:
import adios2
?
There was a problem hiding this comment.
Yep, this might be better in case they revert the bindings at some point
There was a problem hiding this comment.
The disadvantage with the try catch is the yielded exception may be confusing regarding the true nature of the problem. I.e. does adios2 exist, or is it simply a scope resolution issue between versions of the package.
There was a problem hiding this comment.
what about:
def import_adios():
try:
import adios2
return adios2.bindings
except AttributeError:
import adios2
return adios2
jorgensd
reviewed
Feb 8, 2024
nate-sime
commented
Feb 8, 2024
Merged
jorgensd
added a commit
that referenced
this pull request
Feb 9, 2024
jorgensd
added a commit
that referenced
this pull request
Feb 9, 2024
* Add openmpi and failing adios2 version to CI. * Remove formatting-check from openmpi * Add petsc_arch * Fix outsize dtype * Add debug print * Remove error from print * Set environment variable * Revert debug print * Set ompi flags to openmpi pipeline * Deactivate v2.10.0-rc1 waiting for #60
…nate-sime/adios4dolfinx into nate/adios2.10-interface-change
jorgensd
approved these changes
Feb 12, 2024
jorgensd
reviewed
Feb 12, 2024
jorgensd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #59.