This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
expose ListValuesIter
#874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #874 +/- ##
==========================================
+ Coverage 71.48% 71.50% +0.01%
==========================================
Files 335 335
Lines 17969 18147 +178
==========================================
+ Hits 12846 12976 +130
- Misses 5123 5171 +48
Continue to review full report at Codecov.
|
| @@ -13,7 +13,7 @@ pub struct ListValuesIter<'a, A: IterableListArray> { | |||
|
|
|||
| impl<'a, A: IterableListArray> ListValuesIter<'a, A> { | |||
| #[inline] | |||
| pub fn new(array: &'a A) -> Self { | |||
| pub(crate) fn new(array: &'a A) -> Self { | |||
There was a problem hiding this comment.
doesn't this need to be public for you to use it?
There was a problem hiding this comment.
We get it by calling values_iter on a list array. Don't think we need a new publicly? Don't have much opinion about it though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to implement a trait for an arrow defined iterator. This makes that possible.