This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 222
Added support to the Arrow C stream interface (read and write) #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #857 +/- ##
==========================================
- Coverage 71.48% 71.45% -0.04%
==========================================
Files 335 335
Lines 17897 17986 +89
==========================================
+ Hits 12793 12851 +58
- Misses 5104 5135 +31
Continue to review full report at Codecov.
|
jorgecarleitao
force-pushed
the
ffi2
branch
2 times, most recently
from
February 21, 2022 20:09
627a1f9
to
cf2b10b
Compare
Big kudos to @pitrou for the write up of the C stream interface (see apache/arrow#8052); beautifully well written specification very easy to follow and with very little room for ambiguity. |
sydduckworth
pushed a commit
to mindx/arrow2
that referenced
this pull request
Mar 2, 2022
sydduckworth
pushed a commit
to mindx/arrow2
that referenced
this pull request
Mar 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motived by @wjones127 's suggestion here, this PR adds support to read from and write to the Arrow C stream interface.
The C stream interface is in essence FFI of an iterator of arrow arrays with a common
data_type
; it allows implementation A to request a new item from implementation B.Also closes #859