Fixed wrong null_count when slicing a sliced Bitmap

src/bitmap/immutable.rs

@@ -126,7 +126,7 @@ impl Bitmap {
         // count the smallest chunk
         if length < self.length / 2 {
             // count the null values in the slice
-            self.null_count = count_zeros(&self.bytes, offset, length);
+            self.null_count = count_zeros(&self.bytes, self.offset + offset, length);
         } else {
             // subtract the null count of the chunks we slice off
             let start_end = self.offset + offset + length;

src/bitmap/mod.rs

@@ -9,3 +9,32 @@ mod bitmap_ops;
 pub use bitmap_ops::*;
 
 pub mod utils;
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn subslicing_gives_correct_null_count() {
+        let mut base = MutableBitmap::new();
+        base.push(false);
+        base.push(true);
+        base.push(true);
+        base.push(false);
+        base.push(false);
+        base.push(true);
+        base.push(true);
+        base.push(true);
+
+        let base = Bitmap::from(base);
+        assert_eq!(base.null_count(), 3);
+
+        let view1 = base.clone().slice(0, 1);
+        let view2 = base.slice(1, 7);
+        assert_eq!(view1.null_count(), 1);
+        assert_eq!(view2.null_count(), 2);
+
+        let view3 = view2.slice(0, 1);
+        assert_eq!(view3.null_count(), 0);
+    }
+}