Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

inline push #835

Merged
merged 1 commit into from
Feb 14, 2022
Merged

inline push #835

merged 1 commit into from
Feb 14, 2022

Conversation

ritchie46
Copy link
Collaborator

This add MutableUtf8Array::push so that a branch caused push(Some(value)) maybe optimized away.

Maybe we could consider push_value and push_null variants that don't call the code with the Option branches?

@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #835 (12b2249) into main (601fa08) will increase coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
+ Coverage   71.08%   71.54%   +0.46%     
==========================================
  Files         319      327       +8     
  Lines       16672    17727    +1055     
==========================================
+ Hits        11851    12683     +832     
- Misses       4821     5044     +223     
Impacted Files Coverage Δ
src/array/utf8/mutable.rs 81.03% <ø> (+0.56%) ⬆️
src/io/parquet/read/boolean/nested.rs 50.00% <0.00%> (-38.24%) ⬇️
src/array/utf8/mod.rs 64.58% <0.00%> (-23.08%) ⬇️
src/io/parquet/write/binary/basic.rs 55.68% <0.00%> (-13.64%) ⬇️
src/array/boolean/mod.rs 71.23% <0.00%> (-11.13%) ⬇️
src/io/parquet/read/binary/utils.rs 66.66% <0.00%> (-9.10%) ⬇️
src/io/parquet/read/statistics/binary.rs 65.51% <0.00%> (-5.92%) ⬇️
src/io/avro/read/nested.rs 38.93% <0.00%> (-5.51%) ⬇️
src/io/parquet/write/utf8/basic.rs 66.66% <0.00%> (-4.77%) ⬇️
src/io/parquet/read/nested_utils.rs 73.77% <0.00%> (-4.66%) ⬇️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 601fa08...12b2249. Read the comment docs.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Feb 14, 2022
@jorgecarleitao jorgecarleitao merged commit dded624 into jorgecarleitao:main Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants