This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Added support to read Arrow streams asynchronously #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecarleitao
force-pushed
the
async_stream
branch
from
f5ac25b
to
2da6078
Compare
jorgecarleitao
changed the title
async Arrow stream reading
Codecov Report
@@ Coverage Diff @@
## main #832 +/- ##
==========================================
- Coverage 71.55% 71.55% -0.01%
==========================================
Files 326 327 +1
Lines 17643 17737 +94
==========================================
+ Hits 12624 12691 +67
- Misses 5019 5046 +27
Continue to review full report at Codecov.
|
jorgecarleitao
force-pushed
the
async_stream
branch
from
115e717
to
422c5a8
Compare
jorgecarleitao
force-pushed
the
async_stream
branch
from
422c5a8
to
f9696ff
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to read an arrow stream asynchronously (via
futures::AsyncRead), thereby allowing users to use their favorite runtime to suspend reading from it when either the stream is marked as "waiting", or the reader is not ready (e.g. network).The design is equivalent to the rest of the IO in the crate. Recall that we do not separate IO-bounded from CPU-bounded ops when reading and writing to Arrow IPC because arrow IPC format has almost no CPU involved (it is reading/writing back-to-back).