Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added MutableUtf8Array::extend_values #798

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

ritchie46
Copy link
Collaborator

MutableUtf8Array already has Extend for iterators over Option<S: AsRef<str> and iterators over values and optional values from trusted length iterators, but not yet a method for iterators over values whose length cannot be trusted.

This PR adds that.

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #798 (b50ac47) into main (777f375) will increase coverage by 0.02%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
+ Coverage   71.50%   71.53%   +0.02%     
==========================================
  Files         321      321              
  Lines       16739    16755      +16     
==========================================
+ Hits        11970    11986      +16     
  Misses       4769     4769              
Impacted Files Coverage Δ
src/array/utf8/mutable.rs 80.45% <90.90%> (-0.02%) ⬇️
src/array/physical_binary.rs 98.09% <100.00%> (+0.22%) ⬆️
src/io/parquet/read/nested_utils.rs 78.43% <0.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777f375...b50ac47. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit e577c9f into jorgecarleitao:main Feb 3, 2022
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Feb 3, 2022
@jorgecarleitao jorgecarleitao changed the title MutableUtf8Array::extend_values Added MutableUtf8Array::extend_values Feb 3, 2022
@ritchie46 ritchie46 deleted the from_iter_variants branch February 3, 2022 16:54
@jorgecarleitao jorgecarleitao added feature A new feature and removed enhancement An improvement to an existing feature labels Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants