Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Replaced un-needed unsafe #755

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Replaced un-needed unsafe #755

merged 1 commit into from
Jan 11, 2022

Conversation

jorgecarleitao
Copy link
Owner

There is likely some perf improvement given that there are less bound checks, but I have not benched it.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Jan 11, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #755 (05e0af0) into main (2493f7d) will decrease coverage by 0.01%.
The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
- Coverage   70.80%   70.79%   -0.02%     
==========================================
  Files         313      313              
  Lines       16930    17095     +165     
==========================================
+ Hits        11988    12103     +115     
- Misses       4942     4992      +50     
Impacted Files Coverage Δ
src/compute/aggregate/min_max.rs 65.90% <56.25%> (-0.76%) ⬇️
src/compute/comparison/mod.rs 38.82% <0.00%> (-0.72%) ⬇️
src/compute/nullif.rs 0.00% <0.00%> (ø)
src/io/parquet/write/stream.rs 0.00% <0.00%> (ø)
src/compute/comparison/primitive.rs 100.00% <0.00%> (ø)
src/io/parquet/read/nested_utils.rs 78.43% <0.00%> (+0.98%) ⬆️
src/io/json/read/infer_schema.rs 86.98% <0.00%> (+6.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2493f7d...05e0af0. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 2b0e807 into main Jan 11, 2022
@jorgecarleitao jorgecarleitao deleted the min_max_binary branch January 11, 2022 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant