-
Notifications
You must be signed in to change notification settings - Fork 222
Replace flatbuffers dependency by Planus #732
Conversation
Codecov Report
@@ Coverage Diff @@
## main #732 +/- ##
==========================================
+ Coverage 71.02% 71.11% +0.09%
==========================================
Files 315 316 +1
Lines 16950 16782 -168
==========================================
- Hits 12038 11934 -104
+ Misses 4912 4848 -64
Continue to review full report at Codecov.
|
d428806
to
f31d65c
Compare
Added MIRI check to a round-trip over IPC. All still green. |
I though that this would take longer, but it is essentially done: tests pass, MIRI checks pass, simpler to use and a safer design. One step missing is benchmarks of read and write, to check if there is no major regression. @sundy-li , @ritchie46 , @houqp, @yjshen , any thoughts on this? My opinion is that flatbuffers is unmaintained and has soundness issues, which is a concern because IO is an obvious attack vector - it does not mean that |
@jorgecarleitao While I am not going to give any guarantees (this being a hobby, open source project after all), my current plan is to maintain and improve upon the library for at least the next year, since we are planning to use the library in product at skybox.gg. What happens after that is too far into the future for me to predict and also depends on whether there is any community adoption. |
a40b725
to
30aca17
Compare
4594ca7
to
792df39
Compare
792df39
to
f64209d
Compare
This PR will stay here for some time. It replaces the flatbuffers crate by planus, a recently released replacement to flatbuffers. See #725 for details.
This switches one for the other. All tests and integration tests pass, showing that it does indeed work as advertised 💯