Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Allow to create primitive array by vec without extra memcopy #710

Merged
merged 1 commit into from
Dec 25, 2021

Conversation

sundy-li
Copy link
Collaborator

@sundy-li sundy-li commented Dec 25, 2021

from_vec is a faster way to create primitive array than from_slice.

@codecov
Copy link

codecov bot commented Dec 25, 2021

Codecov Report

Merging #710 (9a6024c) into main (dfa6370) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
- Coverage   70.16%   70.15%   -0.01%     
==========================================
  Files         309      309              
  Lines       16800    16802       +2     
==========================================
+ Hits        11787    11788       +1     
- Misses       5013     5014       +1     
Impacted Files Coverage Δ
src/util/bench_util.rs 0.00% <ø> (ø)
src/array/primitive/from_natural.rs 80.00% <100.00%> (+2.22%) ⬆️
src/io/avro/read/schema.rs 52.63% <0.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfa6370...9a6024c. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 87a08f4 into jorgecarleitao:main Dec 25, 2021
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Dec 25, 2021
@jorgecarleitao
Copy link
Owner

Thanks a lot!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants