This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently representing arrays in
Debug
is a bit verbose. This was useful to iterate over the struct definitions, but as the API stabilizes, we can move to less verbose representations.This PR goes in this direction by removing the
impl Display
of the Array and by making theDebug
one equal to the currentDisplay
one. This allows users to implDebug
on structs that contain arrays and have an easier to read string representation.This follows the same design used by
std::Vec
, which does not present the struct details to the users.This also removes the
Display
implementation to the datatypes, since it was equal toDebug
(and there is no natural Display for them in Arrow).