Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added integration tests for other compressions with parquet from pyarrow #674

Merged
merged 1 commit into from
Dec 12, 2021

Conversation

jorgecarleitao
Copy link
Owner

The tests are ignored due to https://issues.apache.org/jira/browse/ARROW-15073, but since I took the time at generalizing the tests, we may as well incorporate them.

@jorgecarleitao jorgecarleitao added the testing PRs that only increase coverage label Dec 11, 2021
@jorgecarleitao
Copy link
Owner Author

Thanks to @alexander-beedie for the initial report at pola-rs/polars#2018

@jorgecarleitao jorgecarleitao changed the title Added tests for other compressions parquet Added integration tests for other compressions with parquet from pyarrow Dec 11, 2021
@codecov
Copy link

codecov bot commented Dec 11, 2021

Codecov Report

Merging #674 (34cf7f7) into main (2b86bc9) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
- Coverage   69.60%   69.60%   -0.01%     
==========================================
  Files         301      301              
  Lines       16765    16765              
==========================================
- Hits        11670    11669       -1     
- Misses       5095     5096       +1     
Impacted Files Coverage Δ
src/bitmap/utils/slice_iterator.rs 91.04% <0.00%> (-1.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b86bc9...34cf7f7. Read the comment docs.

@alexander-beedie
Copy link
Contributor

alexander-beedie commented Dec 12, 2021

Thanks to @alexander-beedie for the initial report at pola-rs/polars#2018

You're welcome - will run some more tests at my end on all other possible compression permutations and see if anything else comes up. I suspect we're all going to get a lot of mileage out of the arrow2/polars/connectorx ecosystem in the future, so happy to help! Great projects.

@jorgecarleitao jorgecarleitao merged commit 915cb6c into main Dec 12, 2021
@jorgecarleitao jorgecarleitao deleted the tests_compression branch December 12, 2021 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing PRs that only increase coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants