Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed error in trait constraint in compute #665

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Conversation

jorgecarleitao
Copy link
Owner

The trait was not being applied to all arithmetics which allowed some to be applied to the Decimal type.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Dec 8, 2021
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #665 (bbe5ee5) into main (a18555c) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
+ Coverage   69.59%   69.66%   +0.06%     
==========================================
  Files         299      301       +2     
  Lines       16746    16800      +54     
==========================================
+ Hits        11655    11704      +49     
- Misses       5091     5096       +5     
Impacted Files Coverage Δ
src/compute/arithmetics/basic/add.rs 89.36% <ø> (ø)
src/compute/arithmetics/basic/div.rs 77.96% <ø> (ø)
src/compute/arithmetics/basic/mod.rs 0.00% <ø> (ø)
src/compute/arithmetics/basic/mul.rs 89.36% <ø> (ø)
src/compute/arithmetics/basic/pow.rs 100.00% <ø> (ø)
src/compute/arithmetics/basic/rem.rs 84.90% <ø> (ø)
src/compute/arithmetics/basic/sub.rs 89.36% <ø> (ø)
src/compute/arithmetics/mod.rs 69.04% <ø> (ø)
src/compute/utils.rs 72.72% <0.00%> (-2.28%) ⬇️
src/scalar/utf8.rs 92.30% <0.00%> (-2.14%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a18555c...bbe5ee5. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 15dc6c5 into main Dec 10, 2021
@jorgecarleitao jorgecarleitao deleted the fix_trait branch December 10, 2021 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant