Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Improved performance in cast Primitive to Binary/String (2x) #646

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

sundy-li
Copy link
Collaborator

@sundy-li sundy-li commented Nov 30, 2021

Reuse the temp bytes buffer.

cast int32 to binary 512                                                                             
		time:   [10.650 us 10.761 us 10.885 us]
		change: [-47.175% -46.939% -46.649%] (p = 0.00 < 0.05)
		Performance has improved.

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #646 (26f11b9) into main (a2d84d9) will decrease coverage by 0.00%.
The diff coverage is 82.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #646      +/-   ##
==========================================
- Coverage   69.91%   69.91%   -0.01%     
==========================================
  Files         299      299              
  Lines       16628    16647      +19     
==========================================
+ Hits        11626    11639      +13     
- Misses       5002     5008       +6     
Impacted Files Coverage Δ
src/compute/cast/primitive_to.rs 76.24% <82.60%> (+0.31%) ⬆️
src/util/lexical.rs 50.00% <0.00%> (-25.00%) ⬇️
src/bitmap/utils/slice_iterator.rs 91.04% <0.00%> (-1.50%) ⬇️
src/io/parquet/read/nested_utils.rs 77.45% <0.00%> (-0.99%) ⬇️
src/array/utf8/mutable.rs 85.77% <0.00%> (+0.39%) ⬆️
src/array/binary/mutable.rs 80.16% <0.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2d84d9...26f11b9. Read the comment docs.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Nov 30, 2021
@jorgecarleitao jorgecarleitao changed the title Improve performance in cast Primitive to Binary/String [2X] Improved performance in cast Primitive to Binary/String (2x) Nov 30, 2021
@jorgecarleitao jorgecarleitao merged commit 23c7d8a into jorgecarleitao:main Nov 30, 2021
@jorgecarleitao
Copy link
Owner

Thanks @sundy-li ! Great idea!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants