-
Notifications
You must be signed in to change notification settings - Fork 222
Added iterator for StructArray
#613
Added iterator for StructArray
#613
Conversation
Codecov Report
@@ Coverage Diff @@
## main #613 +/- ##
==========================================
- Coverage 79.61% 79.58% -0.04%
==========================================
Files 403 406 +3
Lines 24838 24882 +44
==========================================
+ Hits 19775 19802 +27
- Misses 5063 5080 +17
Continue to review full report at Codecov.
|
Thanks for the PR! No need for an issue :) The iterators of arrays are iterators over rows. An iterator over a StructArray would be something like |
Thanks for your comments! I understood it wrong. Maybe, I think I have corrected it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @illumination-k, Looks great!
I left a comment to simplify the loop.
The idea in Rust is that when using iterator pattern, rust skips bound checks (it also makes it a bit easier to read for non-C developers)
StructArray
I implemented Iterator for StructArray.
Also, the
struct_.rs
file was changed to a directory withmod.rs
and theffi
part was split intoffi.rs
.If you need me to open an issue on this PR, I will do it.