Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Improved performance of decimal arithmetics #605

Merged
merged 3 commits into from
Nov 14, 2021
Merged

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Nov 14, 2021

  • Moved some operations to outside the hot loop.
  • Removed some collects to Vec
  • DRYed most of it.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Nov 14, 2021
@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #605 (41e98d4) into main (73ee16d) will increase coverage by 0.11%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
+ Coverage   79.37%   79.49%   +0.11%     
==========================================
  Files         401      401              
  Lines       24966    24915      -51     
==========================================
- Hits        19817    19806      -11     
+ Misses       5149     5109      -40     
Impacted Files Coverage Δ
src/compute/arithmetics/decimal/mod.rs 100.00% <ø> (ø)
src/compute/arithmetics/decimal/mul.rs 92.42% <93.02%> (+11.90%) ⬆️
src/compute/arithmetics/decimal/div.rs 92.30% <95.55%> (+11.53%) ⬆️
src/compute/arithmetics/decimal/add.rs 96.42% <100.00%> (+13.81%) ⬆️
src/compute/arithmetics/decimal/sub.rs 96.36% <100.00%> (+13.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73ee16d...41e98d4. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 7f973ee into main Nov 14, 2021
@jorgecarleitao jorgecarleitao deleted the simple_decimal branch November 14, 2021 08:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant