This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Do not check offsets or utf8 validity in ffi (#505) #510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As declared in the spec, the purpose of FFI is to be a very low cost API. The method is already intrinsically unsafe because the data must already follow the spec.
Changed
Utf8Array::try_from_ffi
andBinaryArray::try_from_ffi
to usefrom_data_unchecked
instead offrom_data
.