Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Use static-typed equal functions directly #507

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

yjhmelody
Copy link
Contributor

I am not sure if this will improve performance and affect API semantics?

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #507 (68fe724) into main (9163616) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #507   +/-   ##
=======================================
  Coverage   80.18%   80.18%           
=======================================
  Files         381      381           
  Lines       23659    23659           
=======================================
+ Hits        18970    18971    +1     
+ Misses       4689     4688    -1     
Impacted Files Coverage Δ
src/array/equal/mod.rs 90.32% <100.00%> (ø)
src/io/avro/read/schema.rs 55.95% <0.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9163616...68fe724. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title chore: use static-typed equal functions directly instead Use static-typed equal functions directly Oct 8, 2021
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Oct 8, 2021
@jorgecarleitao
Copy link
Owner

Simpler is better :)

@jorgecarleitao jorgecarleitao merged commit 8a7f1d7 into jorgecarleitao:main Oct 8, 2021
@yjhmelody yjhmelody deleted the array-equal branch October 9, 2021 02:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants