Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Made writing stream to parquet require a non-static lifetime #471

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

GrandChaman
Copy link
Contributor

Hello !

Would it be possible to change the lifetime of the iterators to something a little less restrictive when writing to a parquet file ?

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Sep 30, 2021
Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most definitely! Not sure why they were marked as 'static in the first place, but it is definitely a bug.

Also, very cool picture =)

Thanks for the patch!

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #471 (7937e91) into main (2db7f57) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
- Coverage   80.04%   80.03%   -0.01%     
==========================================
  Files         371      371              
  Lines       22848    22848              
==========================================
- Hits        18288    18287       -1     
- Misses       4560     4561       +1     
Impacted Files Coverage Δ
src/io/avro/read/schema.rs 41.37% <0.00%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db7f57...7937e91. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title Replaced writing stream lifetime with non-static lifetime Made writing stream to parquet require a non-static lifetime Sep 30, 2021
@jorgecarleitao jorgecarleitao merged commit b78eeb7 into jorgecarleitao:main Sep 30, 2021
@GrandChaman GrandChaman deleted the stream_lifetime branch September 30, 2021 08:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants