-
Notifications
You must be signed in to change notification settings - Fork 222
expose shrink_to_fit
to mutable arrays
#467
Conversation
shrink_to_fit
to mutable arrays
Codecov Report
@@ Coverage Diff @@
## main #467 +/- ##
==========================================
- Coverage 80.33% 80.16% -0.18%
==========================================
Files 374 374
Lines 22919 22969 +50
==========================================
+ Hits 18413 18414 +1
- Misses 4506 4555 +49
Continue to review full report at Codecov.
|
Yeap, makes a lot of sense. |
I can take care of the |
Done in #468 |
Great, once #468 is in main, I will do the rebase and add the |
f8196bc
to
f70122b
Compare
Good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks a lot, @ritchie46 ! We are missing one buffer xD
Co-authored-by: Jorge Leitao <[email protected]>
This PR proposes to expose
shrink_to_fit
on the mutable arrays. TheMutableBuffer
already implements this, but its impossible to call with mutable array API as the internal buffers are private.The same could be done for
MutableBitmap
.