Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Made importing from FFI unsafe #458

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Made importing from FFI unsafe #458

merged 1 commit into from
Sep 27, 2021

Conversation

jorgecarleitao
Copy link
Owner

Using FFI is an intrinsically unsafe operation. However, our public API was marked as safe. This PR changes this.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #458 (8d3554e) into main (90887c2) will decrease coverage by 0.00%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   80.01%   80.00%   -0.01%     
==========================================
  Files         371      371              
  Lines       22833    22833              
==========================================
- Hits        18269    18267       -2     
- Misses       4564     4566       +2     
Impacted Files Coverage Δ
arrow-pyarrow-integration-testing/src/lib.rs 0.00% <ø> (ø)
src/array/boolean/ffi.rs 0.00% <0.00%> (ø)
src/array/ffi.rs 68.42% <ø> (ø)
src/array/struct_.rs 35.48% <0.00%> (ø)
src/array/union/ffi.rs 0.00% <0.00%> (ø)
src/array/binary/ffi.rs 84.61% <100.00%> (ø)
src/array/dictionary/ffi.rs 75.00% <100.00%> (ø)
src/array/list/ffi.rs 80.00% <100.00%> (ø)
src/array/primitive/ffi.rs 75.00% <100.00%> (ø)
src/array/utf8/ffi.rs 77.77% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90887c2...8d3554e. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit aee543e into main Sep 27, 2021
@jorgecarleitao jorgecarleitao deleted the unsafe_ffi branch September 27, 2021 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant