Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added extend_*values to MutablePrimitiveArray #383

Merged
merged 3 commits into from
Sep 6, 2021
Merged

Added extend_*values to MutablePrimitiveArray #383

merged 3 commits into from
Sep 6, 2021

Conversation

ritchie46
Copy link
Collaborator

adds

  • extend_trusted_len_values
  • extend_trusted_len_values_unchecked
  • extend_from_slice

@ritchie46
Copy link
Collaborator Author

The changes in src/compute/like.rs are due to $ cargo fmt. I could remove those.

@codecov
Copy link

codecov bot commented Sep 6, 2021 •
edited
Loading

Codecov Report

Merging #383 (ddba388) into main (877739b) will increase coverage by 0.03%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   81.12%   81.15%   +0.03%     
==========================================
  Files         331      331              
  Lines       21957    21994      +37     
==========================================
+ Hits        17813    17850      +37     
  Misses       4144     4144
Impacted Files Coverage Δ
src/compute/like.rs 60.39% <0.00%> (ø)
src/array/primitive/mutable.rs 87.80% <85.71%> (+1.03%) ⬆️
src/bitmap/mutable.rs 89.16% <100.00%> (-0.05%) ⬇️
tests/it/array/primitive/mutable.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 877739b...ddba388. Read the comment docs.

jorgecarleitao
jorgecarleitao reviewed Sep 6, 2021
View reviewed changes
src/array/primitive/mutable.rs Show resolved Hide resolved
src/array/primitive/mutable.rs Show resolved Hide resolved
src/array/primitive/mutable.rs Show resolved Hide resolved
src/array/primitive/mutable.rs Outdated Show resolved Hide resolved
src/array/primitive/mutable.rs Outdated Show resolved Hide resolved
src/array/primitive/mutable.rs Outdated Show resolved Hide resolved
src/array/primitive/mutable.rs Outdated Show resolved Hide resolved
@jorgecarleitao
Copy link
Owner

thanks a lot @ritchie46 ! Looks great so far. Left minor comments and it is almost ready to go.

jorgecarleitao and others added 3 commits September 6, 2021 15:18
@jorgecarleitao
Fixed error in pushing bit.
6d55d31
@ritchie46
improve MutablePrimitiveArray
d5dcffd 
adds

* extend_trusted_len_values
* extend_trusted_len_values_unchecked
* extend_from_slice
@ritchie46
process comments and apply them to 'extend_trusted_len' as well
ddba388
@jorgecarleitao jorgecarleitao changed the title improve MutablePrimitiveArray Added extend_*values to MutablePrimitiveArray Sep 6, 2021
@jorgecarleitao jorgecarleitao merged commit 4e4ea28 into jorgecarleitao:main Sep 6, 2021
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jorgecarleitao jorgecarleitao jorgecarleitao left review comments

Assignees
No one assigned
Labels
enhancement An improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritchie46 @jorgecarleitao