Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Made cargo features not default #369

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Made cargo features not default #369

merged 1 commit into from
Sep 3, 2021

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Sep 2, 2021

This is a request for feedback: basically, it makes most features non-default and introduced a new feature, "full", containing most features.

This follows the same pattern of Tokio-rs (which has many features and a "full"). This makes it easier to start without being overwhelmed by all the dependencies we can potentially bring.

To migrate, pass --features full,benchmarks (or select the features accordingly ^_^)

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #369 (a704d6d) into main (37353bb) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   81.13%   81.17%   +0.04%     
==========================================
  Files         326      325       -1     
  Lines       21150    21141       -9     
==========================================
+ Hits        17160    17162       +2     
+ Misses       3990     3979      -11     
Impacted Files Coverage Δ
src/types/mod.rs 28.31% <0.00%> (-0.89%) ⬇️
src/util/bench_util.rs
src/io/json_integration/schema.rs 44.89% <0.00%> (+0.30%) ⬆️
src/io/json/read/reader.rs 75.67% <0.00%> (+1.35%) ⬆️
src/io/json_integration/write.rs 6.25% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37353bb...a704d6d. Read the comment docs.

@jorgecarleitao
Copy link
Owner Author

cc @sundy-li and @ritchie46 , as it impacts you.

@jorgecarleitao jorgecarleitao merged commit dbb7b8a into main Sep 3, 2021
@jorgecarleitao jorgecarleitao deleted the features branch September 3, 2021 13:39
@jorgecarleitao jorgecarleitao changed the title Made most features not default Made cargo features not default Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant