This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Added support for Extension
(logical) type
#359
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Arrow's
Extension
"DataType", enabling users to define and use custom data types from Arrow's ecosystem.Note that, from now on, array's
data_type
is not sufficient to downcast an array. I have updated the user guide with the new rules. The easiest way to think about them:enum PhysicalType
has a one-to-one relationship to concrete arrays (e.g.PhysicalType::Utf8 <-> Utf8Array<i32>
)enum DataType
has a many-to-one relationship with aPhysicalType
, which can be obtained via.to_physical_type() -> PhysicalType
.The corollary of this change is that, to correctly downcast arrays, users should now use
match array.data_type().to_physical_type()
. This is only relevant to theExtensionType
, which boxes aDataType
which indicates its own logical type.Thanks to @sundy-li for the initial implementation at #338 and follow-up discussions at #350.
Closes #361