Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Simplified code of json schema inference #339

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

jorgecarleitao
Copy link
Owner

The inference depended on the Ord of DataType, which is not ideal because DataType are not ordered.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Aug 25, 2021
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #339 (99cd438) into main (f79ae3e) will decrease coverage by 0.00%.
The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   80.97%   80.97%   -0.01%     
==========================================
  Files         326      326              
  Lines       21167    21189      +22     
==========================================
+ Hits        17141    17158      +17     
- Misses       4026     4031       +5     
Impacted Files Coverage Δ
src/io/json/read/infer_schema.rs 90.83% <90.62%> (+2.16%) ⬆️
tests/it/io/csv/read.rs 100.00% <0.00%> (ø)
src/array/equal/mod.rs 91.26% <0.00%> (+1.58%) ⬆️
src/io/csv/read/deserialize.rs 60.28% <0.00%> (+4.03%) ⬆️
src/io/json_integration/write.rs 6.25% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f79ae3e...99cd438. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit ffacc38 into main Aug 25, 2021
@jorgecarleitao jorgecarleitao deleted the simpler_json_inference branch August 25, 2021 22:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant