Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Generalized ZipIterator to accept a BitmapIter #296

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Conversation

jorgecarleitao
Copy link
Owner

Rational

It allows to re-use the ZipValidity on MutableArrays.

backwards incompatible

bitmap::utils::zip_validity and bitmap::utils::ZipValidity::new now expect a BitmapIter in their arguments.

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #296 (14ed0b5) into main (fa3b003) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
+ Coverage   77.51%   77.53%   +0.01%     
==========================================
  Files         315      315              
  Lines       20967    20977      +10     
==========================================
+ Hits        16253    16264      +11     
+ Misses       4714     4713       -1     
Impacted Files Coverage Δ
src/array/binary/iterator.rs 87.50% <100.00%> (+0.83%) ⬆️
src/array/boolean/iterator.rs 71.42% <100.00%> (+4.76%) ⬆️
src/array/dictionary/iterator.rs 50.00% <100.00%> (+2.38%) ⬆️
src/array/fixed_size_binary/iterator.rs 64.28% <100.00%> (+2.74%) ⬆️
src/array/fixed_size_list/iterator.rs 55.55% <100.00%> (+5.55%) ⬆️
src/array/list/iterator.rs 62.50% <100.00%> (+1.63%) ⬆️
src/array/primitive/iterator.rs 60.00% <100.00%> (+10.00%) ⬆️
src/array/utf8/iterator.rs 68.18% <100.00%> (+1.51%) ⬆️
src/bitmap/utils/zip_validity.rs 95.65% <100.00%> (-0.35%) ⬇️
tests/it/bitmap/utils/zip_validity.rs 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa3b003...14ed0b5. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 2c7f6f9 into main Aug 18, 2021
@jorgecarleitao jorgecarleitao deleted the prep_iter branch August 18, 2021 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant