Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Made CSV and JSON tests not use files. #290

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Made CSV and JSON tests not use files. #290

merged 1 commit into from
Aug 16, 2021

Conversation

jorgecarleitao
Copy link
Owner

This makes testing easier and allows miri to check them.

Also greatly simplified them.

This allows miri to check them, and make the testing less reliant
on a FS, which it does not actually need.
@jorgecarleitao jorgecarleitao changed the title Made CSV and JSON not use files. Made CSV and JSON tests not use files. Aug 16, 2021
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Aug 16, 2021
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #290 (e4b77b1) into main (a5f0575) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
- Coverage   77.36%   77.25%   -0.12%     
==========================================
  Files         315      315              
  Lines       20936    20791     -145     
==========================================
- Hits        16198    16062     -136     
+ Misses       4738     4729       -9     
Impacted Files Coverage Δ
src/io/json/read/infer_schema.rs 88.66% <ø> (ø)
src/io/json/read/reader.rs 75.67% <ø> (-14.87%) ⬇️
tests/it/io/csv/read.rs 100.00% <100.00%> (ø)
tests/it/io/json/mod.rs 100.00% <100.00%> (ø)
tests/it/io/json/read.rs 100.00% <100.00%> (ø)
src/io/json/read/deserialize.rs 70.86% <0.00%> (-2.37%) ⬇️
src/array/mod.rs 47.73% <0.00%> (+1.50%) ⬆️
src/array/dictionary/mod.rs 72.50% <0.00%> (+7.50%) ⬆️
src/array/boolean/mutable.rs 58.51% <0.00%> (+12.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f0575...e4b77b1. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 0742edd into main Aug 16, 2021
@jorgecarleitao jorgecarleitao deleted the json_improve branch August 16, 2021 09:47
@jorgecarleitao jorgecarleitao added testing PRs that only increase coverage and removed enhancement An improvement to an existing feature labels Aug 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing PRs that only increase coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant