Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support for FFI of dictionary-encoded arrays #267

Merged
merged 3 commits into from
Aug 11, 2021
Merged

Conversation

jorgecarleitao
Copy link
Owner

out of abundance of caution, I have also ran cargo valgrind test --lib --no-default-features, which runs the tests behind valgrind, to make sure no memory leaks are detected.

@jorgecarleitao jorgecarleitao added the feature A new feature label Aug 10, 2021
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #267 (f774364) into main (bfb4910) will increase coverage by 0.16%.
The diff coverage is 63.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   77.37%   77.53%   +0.16%     
==========================================
  Files         232      234       +2     
  Lines       20108    20207      +99     
==========================================
+ Hits        15558    15668     +110     
+ Misses       4550     4539      -11     
Impacted Files Coverage Δ
src/array/boolean/ffi.rs 0.00% <0.00%> (ø)
src/array/dictionary/mod.rs 65.00% <ø> (+5.90%) ⬆️
src/array/mod.rs 53.15% <ø> (ø)
src/array/ffi.rs 43.24% <33.33%> (+8.10%) ⬆️
src/array/struct_.rs 49.18% <50.00%> (ø)
src/ffi/schema.rs 61.53% <61.53%> (ø)
src/ffi/array.rs 80.00% <64.70%> (-3.53%) ⬇️
src/array/dictionary/ffi.rs 75.00% <75.00%> (ø)
src/ffi/ffi.rs 86.45% <86.36%> (+15.91%) ⬆️
src/array/binary/ffi.rs 81.81% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfb4910...f774364. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit d988539 into main Aug 11, 2021
@jorgecarleitao jorgecarleitao deleted the ffi_dict branch August 11, 2021 06:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant