Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Not Implemented error on compressed IPC. #167

Closed
wants to merge 1 commit into from
Closed

Conversation

jorgecarleitao
Copy link
Owner

Partially addresses #163 : returns a "NotImplementedError" when we trying to read IPC with compression, since it is not yet supported.

@jorgecarleitao
Copy link
Owner Author

cc @ghuls :)

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #167 (c93b3eb) into main (7f2c3c1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   75.63%   75.65%   +0.01%     
==========================================
  Files         212      212              
  Lines       18509    18521      +12     
==========================================
+ Hits        14000    14012      +12     
  Misses       4509     4509              
Impacted Files Coverage Δ
src/io/ipc/read/common.rs 84.78% <100.00%> (+1.44%) ⬆️
src/io/ipc/read/reader.rs 86.40% <100.00%> (+0.68%) ⬆️
src/io/ipc/read/stream.rs 86.13% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2c3c1...c93b3eb. Read the comment docs.

@jorgecarleitao
Copy link
Owner Author

Closing since support was just added.

@jorgecarleitao jorgecarleitao deleted the error_on_ipc branch June 27, 2021 04:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants