Handle numbers in styles (#46)

* add failing test for passing numbers in styles * handle numbers correctly in styles
jorgebucaran · Nov 10, 2017 · ac45747 · ac45747
1 parent b033f20
commit ac45747
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/patch.js b/src/patch.js
@@ -55,7 +55,7 @@ function setElementProp(element, name, value, oldValue) {
   if (name === "key") {
   } else if (name === "style") {
     for (var name in merge(oldValue, (value = value || {}))) {
-      element.style[name] = value[name] || ""
+      element.style[name] = value[name] != null ? value[name] : ""
     }
   } else {
     try {

diff --git a/test/vdom.test.js b/test/vdom.test.js
@@ -590,10 +590,18 @@ testTrees("styles", [
     node: h("div", { style: { color: "blue", float: "left" } }),
     html: `<div style="color: blue; float: left;"></div>`
   },
+  {
+    node: h("div", { style: { opacity: 1 } }),
+    html: `<div style="opacity: 1;"></div>`
+  },
+  {
+    node: h("div", { style: { opacity: 0 } }),
+    html: `<div style="opacity: 0;"></div>`
+  },
   {
     node: h("div"),
     html: `<div style=""></div>`
-  }
+  },
 ])
 
 testTrees("update element data", [