-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update github actions #101
Conversation
Apologies for the delay here, any insight on why the CI failed? |
No worries! It's due to the It seems this has already caused previous jobs to fail. I guess either the EOL versions of Node need to be dropped from CI, or rollup needs to be pinned to a version before v3? |
@kibertoad Does it make sense to remove EOL versions from the workflow already? |
@jorgebucaran Sure! Let's bump colorette to semver major then, as it would mean we no longer promise backwards compatibility |
Wouldn't that be less straightforward initially? Our first step could be to remove the EOL versions from the workflow, which is a simple change aimed solely at fixing the build (currently broken for |
right, so we already don't support them. sure, let's just remove them then |
I get what you're saying. By upgrading to GitHub Actions 3, we officially don't support 10.x and 12.x, although Colorette still works with these versions. |
Well yeah, if our CI is not working, we can't be sure if these versions didn't break at some point. |
This PR bumps GitHub Actions to their latest major versions, which now use Node 16 internally instead of Node 12 (EOL as of end of April 2022, no longer receives security updates):
actions/checkout
can be found hereactions/setup-node
can be found here