Fix detection of dumb terminals on Windows (#91)

jorgebucaran · Jun 3, 2022 · 1674926 · 1674926
1 parent 840f50e
commit 1674926
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -6,16 +6,17 @@ const argv = process.argv || []
 const isDisabled = "NO_COLOR" in env || argv.includes("--no-color")
 const isForced = "FORCE_COLOR" in env || argv.includes("--color")
 const isWindows = process.platform === "win32"
+const isDumbTerminal = env.TERM === "dumb"
 
 const isCompatibleTerminal =
-  tty && tty.isatty && tty.isatty(1) && env.TERM && env.TERM !== "dumb"
+  tty && tty.isatty && tty.isatty(1) && env.TERM && !isDumbTerminal
 
 const isCI =
   "CI" in env &&
   ("GITHUB_ACTIONS" in env || "GITLAB_CI" in env || "CIRCLECI" in env)
 
 export const isColorSupported =
-  !isDisabled && (isForced || isWindows || isCompatibleTerminal || isCI)
+  !isDisabled && (isForced || (isWindows && !isDumbTerminal) || isCompatibleTerminal || isCI)
 
 const replaceClose = (
   index,