-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic testing matrix for combinations of python and numpy versions. #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I left a couple of questions and suggestions, and many of them are actually about the same thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed all issues, but now it's broken
scripts/generate_matrix.py
Outdated
return self.major, self.minor | ||
|
||
@classmethod | ||
def from_str(cls, version_str: str) -> "Version": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add it for now, but it might be useful when differentiating between regular versions and pre-releases
scripts/generate_matrix.py
Outdated
def from_str(cls, version_str: str) -> "Version": | ||
if version_str.count(".") == 1: | ||
version_str += ".0" | ||
return cls(*map(int, version_str.strip().split("."))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True... I assumed we only wanted to test for final releases. I'm explicitly ignoring pre-releases.
not sure if relevant here, but uv supports PEP 723 for defining dependecies in standalone scripts: |
This comment was marked as resolved.
This comment was marked as resolved.
# Conflicts: # .github/workflows/ci.yml # scripts/version_bounds.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this matrix script is becoming rather awesome 😮
It's finally done! And it includes @miloth his tox implementation. |
Partially custom written, partially GPT generated ;)
Let me know if it needs improvements. At least it finally works.