Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop incorrectly using basedpyright --verifytypes #20

Merged
merged 1 commit into from
Sep 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ jobs:
config: ".markdownlint.yaml"
globs: "**/*.md"

- name: install poetry
run: |
- run: |
pipx install poetry poethepoet
poetry config virtualenvs.create true --local
poetry config virtualenvs.in-project true --local
Expand All @@ -36,23 +35,17 @@ jobs:
python-version: "3.10"
cache: poetry

- name: poetry install
- name: install
run: poetry install

- name: ruff check
run: poetry run ruff check --output-format=github
- name: lint (ruff)
run: poe lint --output-format=github

- name: basedpyright --verifytypes --ignoreexternal
run: poetry run basedpyright --ignoreexternal --verifytypes scipy-stubs
- name: verifytypes (basedpyright)
run: poe verifytypes

# TODO: don't continue on error
- name: basedpyright --verifytypes
run: poetry run basedpyright --level error --verifytypes scipy-stubs
continue-on-error: true

# TODO: don't continue on error
- name: mypy.stubtest (based)
# run: poetry run stubtest --concise --ignore-positional-only --mypy-config-file=pyproject.toml --allowlist=tests/stubtest/allowlist.txt scipy
- name: stubtest (basedmypy)
run: poe stubtest -- --concise
continue-on-error: true

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ type = "poetry"

[tool.poe.tasks]
lint = "ruff check"
verifytypes = "basedpyright --level error --verifytypes scipy-stubs"
verifytypes = "basedpyright --ignoreexternal --verifytypes scipy-stubs"

[tool.poe.tasks.stubtest]
cmd = "stubtest --mypy-config-file=pyproject.toml --allowlist=tests/stubtest/allowlist.txt $modules"
Expand Down
Loading