Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added last weight measures #37

Merged
merged 2 commits into from
Oct 16, 2017

Conversation

teunw
Copy link

@teunw teunw commented Oct 12, 2017

No description provided.

Copy link
Owner

@jordanbrauer jordanbrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the fix for the Stone units and then I will pull these into develop. :)


->setSymbol("st")

->setUnits(0.157473044)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the reverse of what we are looking for. Should be 6.35029 (1 stone === 6.35029 kilograms)

@jordanbrauer jordanbrauer merged commit dc7021e into jordanbrauer:develop Oct 16, 2017
@jordanbrauer
Copy link
Owner

LGTM! 👍

jordanbrauer added a commit that referenced this pull request Nov 12, 2017
* remove composer.lock from repo and add it to .gitignore (#30)

* Implement Kilopascal and Megapascal and write tests (#29)

* implement Kilopascal

* implement Megapascal

* fix docblocks

* Fix: add missing self conversions for temperature units (#31)

* Feature/improve travis file (#32)

* update .travis.yml

* Added time measurements (#35)

Closes #10 

* Added time measurements

* Added requested changes

* Added new time units

* Feat: add simple contributing guide for now (#36)

* Added last weight measures (#37)

* Added last weight measures

* Fixed stone units

* Added millibar as pressure unit (#34)

* Added millibar as pressure unit

* Fixed wrong millibar, also fixed documentation block

* Added requested changes

* Added requested changes

* Fixed millibar units

* scientificSymbol property, getter and setter are added (#47)

closes #46

* Add first set of dev docs (#44)

* Update: composer docs cmd now uses bash script to check for stale docs

* Update: phpDocumentor XML config file

* Feat: docs for v0.3.9-alpha (#43)

* Update: move docs directory to project root for github pages support

* Adding energy units (#33)

* Properly casing unit symbols

* Adding requested energy units

* Removing unnecessary imports

* Upgrade: docs & composer version

* Fix: Energy integration test - wrong unit case for Joule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants