Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added inHg and hPa units #158

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Conversation

cezam
Copy link
Contributor

@cezam cezam commented Dec 31, 2020

Types of changes

What types of changes does your code introduce? Check/place an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Description

Added two new pressure units, inches of mercury and hectopascal

Motivation and Context

Needed these in my project, so i thought i'd share ;-)

How Has This Been Tested?

phpunit

@codeclimate
Copy link

codeclimate bot commented Dec 31, 2020

Code Climate has analyzed commit eaaf3a8 and detected 0 issues on this pull request.

View more on Code Climate.

@jordanbrauer
Copy link
Owner

Great stuff! I'm glad this package was of use to you :) I hope there was no fuss using it.

Thanks a lot for your contribution! I will review right after the holidays 😁.

@jordanbrauer jordanbrauer self-requested a review January 5, 2021 00:34
Copy link
Owner

@jordanbrauer jordanbrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@jordanbrauer jordanbrauer merged commit 9870712 into jordanbrauer:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants