Fix #120 (#168)

* use proper unit of measurement * update test to consider new measurement closes #120
jordanbrauer · Mar 26, 2021 · 9b03e3d · 9b03e3d
1 parent 133abc7
commit 9b03e3d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/src/Measure.php b/src/Measure.php
@@ -133,6 +133,8 @@ class Measure
 
     const FREQUENCY = 'frequency';
 
+    const FUEL_ECONOMY = 'fuel_economy';
+
     const LENGTH = "length";
 
     const MASS = "mass";
@@ -190,9 +192,6 @@ class Measure
             Litre::class,
             Millilitre::class,
             Pint::class,
-            KilometrePerLitre::class,
-            LitrePer100Kilometres::class,
-            MilesPerGallon::class,
         ],
         self::MASS => [
             Gram::class,
@@ -279,6 +278,11 @@ class Measure
             Gigabyte::class,
             Terabyte::class,
         ],
+        self::FUEL_ECONOMY => [
+            KilometrePerLitre::class,
+            LitrePer100Kilometres::class,
+            MilesPerGallon::class,
+        ],
     ];
 
     /**

diff --git a/src/Unit/FuelEconomy/FuelEconomyUnit.php b/src/Unit/FuelEconomy/FuelEconomyUnit.php
@@ -29,5 +29,5 @@ abstract class FuelEconomyUnit extends AbstractUnit
 {
     protected $base = KilometrePerLitre::class;
 
-    protected $unitOf = Measure::VOLUME;
+    protected $unitOf = Measure::FUEL_ECONOMY;
 }
diff --git a/tests/unit/Registry/UnitRegistry.spec.php b/tests/unit/Registry/UnitRegistry.spec.php
@@ -83,6 +83,7 @@ public function assertListMeasurementsMethodReturnsArray()
             "energy",
             "frequency",
             "digital_storage",
+            "fuel_economy",
         ];
 
         $this->assertEquals($expected, $actual);