Fix: using new ::configure() method over explicit value definitions

jordanbrauer · Oct 11, 2017 · 35fadfc · 35fadfc
1 parent 969a12f
commit 35fadfc
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 9 deletions.
diff --git a/src/UnitConverter/Unit/Temperature/Celsius.php b/src/UnitConverter/Unit/Temperature/Celsius.php
@@ -26,9 +26,14 @@
  */
 class Celsius extends TemperatureUnit
 {
-  protected $name = "celsius";
+  protected function configure ()
+  {
+    $this
+      ->setName("celsius")
 
-  protected $symbol = "c";
+      ->setSymbol("c")
 
-  protected $units = -272.15;
+      ->setUnits(-272.15)
+      ;
+  }
 }
diff --git a/src/UnitConverter/Unit/Temperature/Fahrenheit.php b/src/UnitConverter/Unit/Temperature/Fahrenheit.php
@@ -26,9 +26,11 @@
  */
 class Fahrenheit extends TemperatureUnit
 {
-  protected $name = "fahrenheit";
+  $this
+    ->setName("fahrenheit")
 
-  protected $symbol = "f";
+    ->setSymbol("f")
 
-  protected $units = -457.87;
+    ->setUnits(-457.87)
+    ;
 }
diff --git a/src/UnitConverter/Unit/Temperature/Kelvin.php b/src/UnitConverter/Unit/Temperature/Kelvin.php
@@ -26,9 +26,14 @@
  */
 class Kelvin extends TemperatureUnit
 {
-  protected $name = "kelvin";
+  protected function configure ()
+  {
+    $this
+      ->setName("kelvin")
 
-  protected $symbol = "k";
+      ->setSymbol("k")
 
-  protected $units = 1;
+      ->setUnits(1)
+      ;
+  }
 }