Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle module __builtins__ both as dict or module #1107

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Handle module __builtins__ both as dict or module #1107

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9a68fa
Handle module __builtins__ both as dict or module
rffontenelle Mar 11, 2024
94384d7
Double quotes to keep black compliance in setup.py
rffontenelle Mar 13, 2024
ed5c81f
Comment on why use set_builtin in setup.py
rffontenelle Mar 14, 2024
7db0575
Extra blank line around function in setup.py
rffontenelle Mar 14, 2024
bf82227
Merge branch 'jopohl:master' into handle_builtin_as_dict
rffontenelle Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,18 @@
)
sys.exit(1)

def set_builtin(name, value):
if isinstance(__builtins__, dict):
__builtins__[name] = value
else:
setattr(__builtins__, name, value)
rffontenelle marked this conversation as resolved.
Show resolved Hide resolved

class build_ext(_build_ext):
def finalize_options(self):
print("Finalizing options")
_build_ext.finalize_options(self)
# Prevent numpy from thinking it is still in its setup process:
__builtins__.__NUMPY_SETUP__ = False
set_builtin('__NUMPY_SETUP__', False)
rffontenelle marked this conversation as resolved.
Show resolved Hide resolved
import numpy

self.include_dirs.append(numpy.get_include())
Expand Down
Loading