Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Koowa::isDebug check for debugging #534

Closed
ercanozkaya opened this issue Sep 8, 2021 · 4 comments · Fixed by #535
Closed

Use Koowa::isDebug check for debugging #534

ercanozkaya opened this issue Sep 8, 2021 · 4 comments · Fixed by #535
Assignees
@ercanozkaya
Labels
refactor
Milestone
v3.5.7

Comments

@ercanozkaya
Copy link
Member

ercanozkaya commented Sep 8, 2021 •
edited by johanjanssens
Loading

  • Add Koowa::isDebug and Koowa::setDebug methods
  • Use Koowa::isDebug instead of xdebug check so that we are sure that only we enable the full on debug experience on framework.

Support tickets
@ercanozkaya ercanozkaya added this to the 3.5 milestone Sep 8, 2021
@ercanozkaya ercanozkaya self-assigned this Sep 8, 2021
@johanjanssens johanjanssens mentioned this issue Sep 8, 2021
Closed
@johanjanssens johanjanssens linked a pull request Sep 8, 2021 that will close this issue
Xdebug 2.9.2 support #526
Closed
ercanozkaya added a commit that referenced this issue Sep 9, 2021
@ercanozkaya
#534: Add Koowa::isDebug and Koowa::setDebug
87bcf48
ercanozkaya added a commit that referenced this issue Sep 9, 2021
@ercanozkaya
#534: PHP8 requires a new way of calculating suppressed errors
37c8247 
See: https://www.php.net/manual/en/language.operators.errorcontrol.php#125938
@github-actions github-actions bot mentioned this issue Sep 9, 2021
Merged
ercanozkaya added a commit that referenced this issue Sep 9, 2021
@ercanozkaya
#534: Better filtering for environment variable
9c71b0d
ercanozkaya added a commit to timble/kodekit that referenced this issue Sep 9, 2021
@ercanozkaya
joomlatools/joomlatools-framework#534: Use KODEKIT_DEBUG to set the d…
8b3e491 
…ebug mode and correctly figure out suppressed errors on PHP8
@amazeika amazeika mentioned this issue Oct 12, 2021
Closed
@amazeika amazeika modified the milestones: 3.5, v3.5.7 Nov 15, 2021
@amazeika amazeika mentioned this issue Nov 15, 2021
Closed
@johanjanssens johanjanssens modified the milestones: 3.5, v3.5.7 Nov 15, 2021
amazeika added a commit that referenced this issue Dec 7, 2021
@amazeika
#534 Do not use JDEBUG for setting the debug property when instantiat…
2535b7e 
…ing the FW
amazeika added a commit that referenced this issue Dec 7, 2021
@amazeika
#534 Condtionally wire our exception handling to Joomla 4
cb43da9
amazeika added a commit that referenced this issue Dec 7, 2021
@amazeika
#534 Let Joomla 4 render errors when JDebug is off
f0b9501
@amazeika
Copy link
Member

amazeika commented Dec 7, 2021

@ercanozkaya Please review these 3 last changes I've made. This normally fixes the debugger and error handling issues we've discussed today on slack. This now works well on both Joomla 3 and 4.

amazeika added a commit that referenced this issue Dec 8, 2021
@amazeika
#534 Check against throwable interface instead
7bc51da
amazeika added a commit that referenced this issue Dec 8, 2021
@amazeika
#534 Make the debugging check before rendering with our own handler
611f45b
amazeika added a commit that referenced this issue Dec 8, 2021
@amazeika
#534 Unset debug
c91a7e5 
This was in for testing only
johanjanssens added a commit that referenced this issue Dec 10, 2021
@johanjanssens
##534 - Fix typo in code comments
89d32c2
johanjanssens added a commit that referenced this issue Dec 10, 2021
@johanjanssens
#534 - Do not use KOOWA_DEBUG env variable
1a5ebbe 
We are not using env variables anywhere else instead set the debug config option externally when instantiating
@johanjanssens
Copy link
Member

@amazeika Did review, and made two smaller changes myself for code that i introduced we don't need. Took it out again.

@johanjanssens johanjanssens changed the title Use KOOWA_DEBUG environment variable for debugging Use Koowa::isDebug check for debugging Dec 10, 2021
@johanjanssens
Copy link
Member

@ercanozkaya I have removed KOOWA_DEBUG, this change will need to be synced with Kodekit, some of the other changes @amazeika has made also need syncing.

johanjanssens added a commit that referenced this issue Dec 10, 2021
@johanjanssens
Revert "#534 - Do not use KOOWA_DEBUG env variable"
4b30579 
This reverts commit 1a5ebbe.
@johanjanssens
Copy link
Member

Reverted last change again, after discussion with Ercan

@johanjanssens johanjanssens reopened this Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ercanozkaya ercanozkaya

Labels
refactor
Projects
None yet
Milestone
v3.5.7
3 participants
@ercanozkaya @johanjanssens @amazeika