Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Pre-update check for extensions AllowDynamicProperties #44307

Open
wants to merge 1 commit into
base: 5.2-dev
Choose a base branch
from

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Oct 18, 2024

Pull Request for Issue #44284 .

Summary of Changes

added #[\AllowDynamicProperties]

Testing Instructions

see #44284 .

Actual result BEFORE applying this Pull Request

deprecation

Expected result AFTER applying this Pull Request

no more derepcation

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Hackwar
Copy link
Member

Hackwar commented Oct 18, 2024

Please add the necessary attributes instead of hiding the error with this code.

@alikon
Copy link
Contributor Author

alikon commented Oct 18, 2024

the only way I was able to reproduce the issue, has been to add a non standard "tag" <updatefromcli>false</updatefromcli> in the updateserver xml file

so we don't know the exact non standard tags that are defined in the updateserver xml file of the extensions for @obuisard it was <length></leght> i suspect, so to avoid errors the #[\AllowDynamicProperties] could be a good solution imho

@obuisard
Copy link
Contributor

obuisard commented Oct 18, 2024

I have found the extension that has <length> in the update server file and it's a VERY popular extension.
My point is, it will be happening on a lot of sites that have error reporting enabled.

@richard67
Copy link
Member

@obuisard Does this PR close your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants