[5.2] add test for site router (sef) #44253
Draft
+392
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heelc29
force-pushed
the
5.2/tests/site-router-sef
branch
6 times, most recently
from
912981f
to
8f83686
Compare
|
You can rename the htaccess.txt in beforeEach to .htaccess and in afterEach back to .txt. |
At the moment I'm struggle a bit with copying/renaming the file. |
heelc29
force-pushed
the
5.2/tests/site-router-sef
branch
3 times, most recently
from
bc70f52
to
58c3249
Compare
heelc29
force-pushed
the
5.2/tests/site-router-sef
branch
from
58c3249
to
b1fd7fc
Compare
heelc29
force-pushed
the
5.2/tests/site-router-sef
branch
from
b1fd7fc
to
c81fd1b
Compare
|
It looks like mod_rewrite is not enabled in docker image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
add tests for site router (sef) and should cover:
Testing Instructions
drone
code review
Actual result BEFORE applying this Pull Request
no sef tests
Expected result AFTER applying this Pull Request
test coverage
Link to documentations
Please select: