Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Move CMS Filesystem package to compat plugin #44240

Open
wants to merge 5 commits into
base: 6.0-dev
Choose a base branch
from

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Oct 12, 2024

Summary of Changes

This PR moves the CMS Filesystem classes to the compat plugin, allowing legacy third party code to still run when the plugin is active, but making the first step to finally remove it from the CMS.

I've added the Composer Dependency Changed label because the PR requires composer i to be run.

Testing Instructions

Copy the following line in a view of your choice to generate a call to the legacy classes:

var_dump(\Joomla\CMS\Filesystem\Folder::listFolderTree(JPATH_BASE, '.'));

Make sure the compat plugin is enabled AND you have to run composer i to generate an updated class loader file
Visit the view you edited in the browser to see an output of the call to the legacy class. Disable the plugin and see an error thrown instead.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo
Copy link
Member

laoneo commented Oct 14, 2024

Please move the "classes" folder outside of the src folder. Like it is now you have the src folder managed by a classloader and then the "classes" folder managed by another classloader. I would also rename the "classes" folder to legacy or so.

@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Oct 14, 2024
@Hackwar
Copy link
Member Author

Hackwar commented Oct 14, 2024

Done

Comment on lines +44 to +45
>
<option value="0">JNO</option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
>
<option value="0">JNO</option>
>
<option value="0">JNO</option>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants