-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.0] Move CMS Filesystem package to compat plugin #44240
Open
Hackwar
wants to merge
5
commits into
joomla:6.0-dev
Choose a base branch
from
Hackwar:6.0-filesystem2
base: 6.0-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+26
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Please move the "classes" folder outside of the src folder. Like it is now you have the src folder managed by a classloader and then the "classes" folder managed by another classloader. I would also rename the "classes" folder to legacy or so. |
Hackwar
force-pushed
the
6.0-filesystem2
branch
from
October 14, 2024 08:20
e776cd0
to
770e5d1
Compare
Done |
sandewt
reviewed
Oct 14, 2024
Comment on lines
+44
to
+45
> | ||
<option value="0">JNO</option> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
> | |
<option value="0">JNO</option> | |
> | |
<option value="0">JNO</option> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR moves the CMS Filesystem classes to the compat plugin, allowing legacy third party code to still run when the plugin is active, but making the first step to finally remove it from the CMS.
I've added the
Composer Dependency Changed
label because the PR requirescomposer i
to be run.Testing Instructions
Copy the following line in a view of your choice to generate a call to the legacy classes:
Make sure the compat plugin is enabled AND you have to run
composer i
to generate an updated class loader fileVisit the view you edited in the browser to see an output of the call to the legacy class. Disable the plugin and see an error thrown instead.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed