[5.3] Run content plugins on custom fields values

[rdeutz]

In the extension development room someone asked, if content plugins replace custom fields values. The correct answer to the question is: It depends.

If you include a field with {fields x} then it can be be replaced, if the content plugins run in the right order. E.g. I made a text field and set it to {loadmoduleid 17}, if the content/field plugin runs before the content/loadmodules plugin then its gets replaced otherwise not.

If the fields is displayed with "Automatic Display" then it is never replaced.

This feels inconsistent.

I had the idea to add a prepare content parameter to the fields like we have this for a custom module. The we could control the replacement better. Opinions please?

Summary of Changes

I have added a new parameter "Prepare Content" to the custom fileds like we have it for a custom module. I made changes to the FieldsHelper and run content plugins when the parameter is set to yes. The default value for "Prepare Content" is no. This can have an effect to the site performance.

I am not sure if we should add this to the core so I will keep it as draft and let the maintainers make an decision.

Testing Instructions

• Create a custom field text
• Create an article and set the custom fields to {loadmoduleid x}; x must be the id of an existing module
• Add some text to the article and add {field y}; y is the id of the created custom field
• Set the article to featured
• Go to the homepage
• Now apply patch
• Change the "Prepare Content" to yes

Actual result BEFORE applying this Pull Request

or when the ordering of the content plugins is fields -> loadmodules

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[Fedik]

just use HTMLHelper::_('content.prepare', $value, '', 'blabla.context');, as it is done in:

joomla-cms/modules/mod_custom/src/Dispatcher/Dispatcher.php

Line 39 in 4f2ae76

($data['module'])->content = HTMLHelper::_('content.prepare', ($data['module'])->content, '', 'mod_custom.content');

and many other places.

[Quy]

Suggested change

	COM_FIELDS_FIELD_PREPARE_CONTENT_DESC="Optionally prepare the content with Joomla Content Plugins."
	COM_FIELDS_FIELD_PREPARE_CONTENT_DESC="Use Joomla Content Plugins to prepare the content."