Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.2] fix update sql for postgres #44123

Merged
merged 1 commit into from
Sep 22, 2024
Merged

[5.2] fix update sql for postgres #44123

merged 1 commit into from
Sep 22, 2024

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Sep 22, 2024 •
edited
Loading

Pull Request for Issue # .
from #44105 (comment)

Summary of Changes

fix update sql for postgres

Testing Instructions

update from 5.1.4 to 5.2 with postgresql

Actual result BEFORE applying this Pull Request

ko

Expected result AFTER applying this Pull Request

ok

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon alikon marked this pull request as ready for review September 22, 2024 06:47
richard67
richard67 approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@richard67 richard67 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t have the time for a real test now, but by review it’s clear that this change is right and necessary.

@richard67
Copy link
Member

@Hackwar @pe7er I think this PR here can be merged by review. It's a no-brainer.

@Hackwar Hackwar merged commit 91e1afc into joomla:5.2-dev Sep 22, 2024
3 checks passed
@Hackwar
Copy link
Member

Hackwar commented Sep 22, 2024

Thank you for your contribution @alikon

@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Sep 22, 2024
@alikon alikon deleted the patch-21 branch September 22, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard67 richard67 richard67 approved these changes

Assignees
No one assigned
Labels
PR-5.2-dev
Projects
None yet
Milestone
Joomla! 5.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@alikon @richard67 @Hackwar @joomla-cms-bot