-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] [Guided tours] Bug fixes for PR #43966 #44075
[5.2] [Guided tours] Bug fixes for PR #43966 #44075
Conversation
Nested Subforms - Allows the nesting of Subform inside a Subform Custom Field. I think its the first option assuming you can only nest one subform otherwise its the second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvements.
The PR #43204 allows the selection of subform fields in a subforms. There could be more than one. So that should be plural. |
administrator/language/en-GB/guidedtours.joomla_whatsnew_5_2.ini
Outdated
Show resolved
Hide resolved
administrator/language/en-GB/guidedtours.joomla_whatsnew_5_2_steps.ini
Outdated
Show resolved
Hide resolved
Thanks for confirming @obuisard I have suggested the correction now |
Co-authored-by: Brian Teeman <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
RTC |
@tecpromotion ??? It doesn't have 2 successful human tests, or am I missing something? Approvals on GitHub just mean the PR is ok by review, but they are not equal to a test of the functionality by a human being. |
Well I just see a review should be sufficient here. But still it needs "testers". |
I have tested this item ✅ successfully on 4095578 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44075. |
I have tested this item ✅ successfully on 4095578 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44075. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44075. |
Thanks for your contribution @obuisard and @brianteeman |
joomla/joomla-cms#44106 - (только для en-GB) joomla/joomla-cms#44075 + joomla/joomla-cms#44093 + joomla/joomla-cms#43694 + joomla/joomla-cms#44082 + joomla/joomla-cms#44110 - (только для en-GB) joomla/joomla-cms#44111 + joomla/joomla-cms#44105 + joomla/joomla-cms#44146 - (только для др. пакетов) joomla/joomla-cms#44142 + joomla/joomla-cms#44127 - (только для en-GB) joomla/joomla-cms#44132 + joomla/joomla-cms#44137 + joomla/joomla-cms#44145 +
Pull Request for PR #43966
Summary of Changes
Add missing file header
Correction of the spelling of the language strings
add "noreferrer" to link
Testing Instructions
It should have no effect on the functionality.
Actual result BEFORE applying this Pull Request
language_string = ""
Expected result AFTER applying this Pull Request
language_string=""
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed