Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] [Guided tours] Bug fixes for PR #43966 #44075

Conversation

tecpromotion
Copy link
Contributor

@tecpromotion tecpromotion commented Sep 13, 2024

Pull Request for PR #43966

Summary of Changes

Add missing file header
Correction of the spelling of the language strings
add "noreferrer" to link

Testing Instructions

It should have no effect on the functionality.

Actual result BEFORE applying this Pull Request

language_string = ""

Expected result AFTER applying this Pull Request

language_string=""

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

brianteeman commented Sep 13, 2024

Nested Subforms - Allows the nesting of Subform inside a Subform Custom Field.
==>
Nested Subforms - Allows the nesting of a Subform inside a Subform Custom Field.
or
Nested Subforms - Allows the nesting of Subforms inside a Subform Custom Field.

I think its the first option assuming you can only nest one subform otherwise its the second

Copy link
Contributor

@obuisard obuisard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvements.

@obuisard
Copy link
Contributor

Nested Subforms - Allows the nesting of Subform inside a Subform Custom Field. ==> Nested Subforms - Allows the nesting of a Subform inside a Subform Custom Field. or Nested Subforms - Allows the nesting of Subforms inside a Subform Custom Field.

I think its the first option assuming you can only nest one subform otherwise its the second

The PR #43204 allows the selection of subform fields in a subforms. There could be more than one. So that should be plural.

@brianteeman
Copy link
Contributor

Thanks for confirming @obuisard I have suggested the correction now

obuisard and others added 2 commits September 14, 2024 11:46
Co-authored-by: Brian Teeman <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
@tecpromotion
Copy link
Contributor Author

RTC

@richard67
Copy link
Member

RTC

@tecpromotion ??? It doesn't have 2 successful human tests, or am I missing something? Approvals on GitHub just mean the PR is ok by review, but they are not equal to a test of the functionality by a human being.

@richard67
Copy link
Member

Well I just see a review should be sufficient here. But still it needs "testers".

@richard67
Copy link
Member

I have tested this item ✅ successfully on 4095578

With a good diff tool I was able to compare the details of the changes in the language string, which the diff on GitHub doesn't show.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44075.

@obuisard
Copy link
Contributor

I have tested this item ✅ successfully on 4095578


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44075.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44075.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 17, 2024
@Hackwar Hackwar merged commit 86e00ce into joomla:5.2-dev Sep 18, 2024
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 18, 2024
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Sep 18, 2024
@Hackwar
Copy link
Member

Hackwar commented Sep 18, 2024

Thanks for your contribution @obuisard and @brianteeman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants